Quantcast
Channel: XWiki Forum - Latest topics
Viewing all articles
Browse latest Browse all 1220

Remove the window menu on electron

$
0
0

Hello,

currently, when using the reload action from the menu in electron, the user ends up in a blank page (Loading...).
When investigating this issue, I noticed that no menu entry are currently useful.

Here is an exhaustive list of all the menu entries and the consequence of not having them on the menu.

  • File
    • Quit (Ctrl+Q): Does not work without the menu, but the native way to quit an app (e.g., Alt+F4 on Linux) is working
  • Edit
    • Undo: works when no menu
    • Redo: works when no menu
    • Cut: works when no menu
    • Copy: works when no menu
    • Paste: works when no menu
    • Delete: apparently does nothing
    • Select all: works when no menu
  • View
    • Reload (Ctrl+R): no need for it
    • Forced reload (Ctrl+Shift+R): no need for it
    • Toggle developer tool (Ctrl+Shift+I): useful, at least when developing
    • Actual size (Ctrl+0): does not work without the menu
    • Zoom in (Ctrl±): does not work without the menu
    • Zoom out (Ctrl++): does not work without the menu
    • Toggle full screen (F11): TODO test without menu
  • Windows
    • Minimize (Ctrl+M): Does not work without menu, but the native way to minimize a window is working (e.g., Win+H on Gnome)
    • zoom: apparently does nothing when the menu is activated
    • Close (Ctrl+W): Does not work without the menu, but the native way to quit an app (e.g., Alt+F4 on Linux) is working
  • Help

Most of them can be removed, but I think a minimal set of actions must be preserved:

  • useful for devs and debug:
    • Toggle developer tool (Ctrl+Shift+I)
  • useful for accessibility
    • Actual size (Ctrl+0)
    • Zoom in (Ctrl±)
    • Zoom out (Ctrl++)
    • Toggle full screen (F11)

Then, we have two options:

  • Option 1: redefine a menu with the minimal set of actions
  • Option 2.1: only bind the shortcuts for useful features
  • Option 2.2: bind the shortcuts but also provide a section about help (this is more work as we’d need to introduce a help UI, and provide a way to inject electron specific details, and maybe also a notion of shortcuts and shortcuts definition)

I’m +1 for option 2.1, and create the improvements to do 2.2 later.

WDYT?

1 post - 1 participant

Read full topic


Viewing all articles
Browse latest Browse all 1220

Trending Articles