Hi devs,
We normally don’t really need to ge formal agreement to remove test code but I’d like to make sure we agree.
The context:
- Some time ago I had introduced a new JUnit5-based way to write rendering tests (using
RenderingTests). I had kept the old JUnit4 way with@RunWith(RenderingTestSuite) - I’ve now migrated all our tests to use
RenderingTests
The proposal:
- To remove, in 17.0.0, the class we don’t use anymore:
RenderingTestSuite
This means that if we have contrib extensions that update to 17.0.0+ and if they had rendering tests, they’ll need to adapt their tests. Fortunately:
- There aren’t that many repos like this
- It’s easy to convert
WDYT?
Thx
5 posts - 3 participants