Hi everyone,
when a page is moved or deleted, we refactor links that point to this page. However, this only works when the links are known to XWiki. Prior to XWIKI-19352 which was implemented in XWiki 14.2, links were indexed synchronously during the saving of the document. Nowadays (since XWiki 14.8+, see XWIKI-16192), links are indexed when a page is indexed in the search index in Solr. This means that when indexing is still running either because of, e.g., a re-indexing operation or a big import, or because the page has just been moved itself, links won’t be adapted anymore.
Back when asynchronous indexing was implemented, it was discussed that refactoring jobs should wait for indexing to be complete and there should be a progress indicator - at least when an admin enables an option to consider the indexing status to be critical. Unfortunately, this waiting has never been implemented and so currently this leads to bugs. The issue XWIKI-22323 has been created to track this regression.
I propose the following changes.
- By default, wait for indexing to complete and display the indexing progress in the job progress (based on the initial number of documents in the queue, a number of steps will be created that are completed as the queue becomes emptier, if the queue size increases again, the remaining steps will be distributed among the newly added documents).
- Add an option in the scripting API (in the job options) to not wait for indexing to complete.
- Add a global
xwiki.propertiesoption to not wait for indexing to complete. - Add an option for advanced users to not wait for indexing in the UI of move and delete jobs that can be enabled when link updating is enabled.
To me, 1 and 2 seem enough, I wouldn’t implement 3 and 4, so +1 for 1 and 2 and -0 for 3 and 4. Any opinions?
1 post - 1 participant