Hello!
Context
On some of the native Live Data tables included in XWiki, displaying the pagination element is unecessary because we do not expect any more element to be created, and there’s only one page.
Proposal
We found out a few ideas when thinking about how to solve it:
A. (initial ticket info filled up by @surli ) Disable the Live Data pagination when there’s less than 10 items in a table.
B. (my take on the issue, proposed in the PR) Disable the Live Data pagination when there’s only one page.
C. (@mleduc 's idea / preference) Keep Live Data pagination except when the corresponding admin parameter is turned ON (default OFF). Then same as B.
D. (additional idea I had) Same as C, but with a macro parameter instead of an admin preference, by default the pagination is always ON.
Explanation
- In my opinion A. is not stable enough, and relying on an empirical value can become a burden for users understanding:
So I add one item in my table and all of a sudden the pagination shows up
. - An advantage of A and B would be that this behaviour would be shared by all the updated wikis. It doesn’t need extra consideration from the Admin when setting up a new wiki, and they allow for the best consistency of the feature.
- An advantage of C and D would be that there is no change to the way a Live Data is displayed.
- An advantage of D would be that we can adopt different policies for different tables, giving the most fine grained control to the user over this new feature.
- An issue of D would be that it makes using the Live Data macro a bit more difficult.
Conclusion
In my opinion D > B > C > A.
What solution do you prefer? Would you rather keep things as is and close the Jira issue as a Won't fix
? Did you think of additional advantages and drawbacks for each solution?
Thank you!
Lucas C.
4 posts - 3 participants